ianrenton / SuccessWhale

:whale: A web-based multi-column social network client. No longer functional or maintained!
BSD 2-Clause "Simplified" License
14 stars 7 forks source link

Regex issue with processing links to some TLDs #18

Closed haku closed 13 years ago

haku commented 13 years ago

Saw this in my timeline today.

2 groupes de facebook qui informent,discutent de la situation au Maroc,interessant : http://on.fb.me/gp32LG , http://on.fb.me/hu0CJ8

Which SW turned into:

RT @bghinalaadl: 2 groupes de facebook qui informent,discutent de la situation au Maroc,interessant : [on].fb.me/gp32LG" target="_blank">[on.fb.me] , [on] ...

It does not seem to like the .fb.me bit.

haku commented 13 years ago

This also happens with URLs that contain a '#':

Thinking about guru plugs http://jtlog.wordpress.com/2011/01/20/facebookicide/#comment-4131

becomes

Thinking about guru plugs #comment-4131" target="_blank">[jtlog.wordpress.com]

ianrenton commented 13 years ago

On the first issue, I can't seem to reproduce it. I DMed myself the tweet with the on.fb.me links in, and they work fine. Can you reproduce it with another tweet?

ianrenton commented 13 years ago

Second issue, it's the slash-hash combination (/#) that's confusing it - that should now be fixed on test, though I haven't pushed source yet.

ianrenton commented 13 years ago

Source pushed, closed. Please re-open if the first issue can be reproduced.