search

ianrose / typesettings

A Sass or Stylus toolkit that sets type in Ems based on modular scale, vertical rhythm, and responsive ratio based headlines.
https://www.typesettings.io
MIT License
387 stars 27 forks source link

More agnostic? #8

Closed danyeah closed 10 years ago

danyeah commented 10 years ago

Hey, i was thinking of switchin from compass to something else (compass is giving hard times with my machine)

I was reading the code and found that you apply some default styles on some elements (font-family, text-transform and such ) which would mean id have to reset them once again in my styles (I always have a _typography.scss file which i style all my h and p )

My question is, wouldn't it be more useful if this library didnt set any default style but gives you only the mixins you need to set the vertical rhythm?

ianrose commented 10 years ago

@danielhq I was thinking the same thing this weekend. I'm glad you've validated that it might be a better direction for Typesettings. Initially Typesettings was something I thought myself and others would copy/paste and manipulate as they see fit. However, I've been using the Bower Version of it. So I totally see where you are coming from. For example, a designer may not want uppercase headlines.

With that said, I've been playing around with the idea of something like _typesettings.scss and _typesetted.scss. _typesettings.scss would only have the mixins and functions. If you wanted to you can separately include _typesetted.scss in your project that would have default styles that leverages _typesettings.scss .

danyeah commented 10 years ago

@ianrose Yes that's definitely the way it should be.

lukelarsen commented 10 years ago

I agree. I would like it setup this way.

ianrose commented 10 years ago

@lukelarsen cool thanks for the feedback :+1: I hope to have a PR this weekend for it.