search

iansan5653 / open-mcr

:pencil: Exam bubble sheet scorer. Created with OpenCV and Python.
GNU General Public License v3.0
160 stars 54 forks source link

Add "Source File" column to output CSV files #48

Closed gajendhir closed 2 years ago

gajendhir commented 2 years ago

resolves #28

gajendhir commented 2 years ago

Ok - I shall do it.

On Mon, Nov 15, 2021, 20:52 Ian Sanders @.***> wrote:

@.**** requested changes on this pull request.

Hello, I was able to test locally today and I just have one small request. Can you also add the file name to the answer key CSV output? It should be as simple as adding the field to the key fields list line 35 of main.py and initializing the field_data dict with the file name field instead of adding the field in line 122.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/iansan5653/open-mcr/pull/48#pullrequestreview-806205259, or unsubscribe https://github.com/notifications/unsubscribe-auth/APKRM3J5QKNQYNUO3IMJN33UMEQS3ANCNFSM5H2AWXPA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

gajendhir commented 2 years ago

I have done it ... Could you please confirm - is the issue number that I have mentioned in my comment while submitting a pull request correct?

Gajendra S. Dhir Data Spec 35, Gurunanak Complex, Dayalband Bilaspur CG 495001 - India Call: +91-7752-405063

On Tue, Nov 16, 2021 at 4:18 AM Ian Sanders @.***> wrote:

Assigned #48 https://github.com/iansan5653/open-mcr/pull/48 to @gajendhir https://github.com/gajendhir.

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/iansan5653/open-mcr/pull/48#event-5621311556, or unsubscribe https://github.com/notifications/unsubscribe-auth/APKRM3N5IAPETFXTUVNNCWTUMGE4TANCNFSM5H2AWXPA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

iansan5653 commented 2 years ago

Yes, looks like the issue number is correct.