search

iansan5653 / open-mcr

:pencil: Exam bubble sheet scorer. Created with OpenCV and Python.
GNU General Public License v3.0
160 stars 54 forks source link

Fix startup error on Linux by only setting TKinter window icon on Windows #56

Closed iansan5653 closed 2 years ago

iansan5653 commented 2 years ago

The .ico file used for the window icon is only compatible with Windows operating systems. Unix based OSes use .xbm files. We might eventually add an XBM file for those machines, but for now it's a minor UI impact to just disable the window icon there so that Linux users can start the app. Fixes #41.

Also expands startup instructions to add more details for both Windows and Unix.

Note: I am unable to test this as I am running Windows. The app does seem to start on my WSL installation, but WSL doesn't support GUIs so I can't actually test it thoroughly. @ayalcin1995 or anyone with Linux / Mac - could you verify that the fix works before I merge this?

ayalcin1995 commented 2 years ago

Sure thing. Give me a few days.

ayalcin1995 commented 2 years ago

Sorry for the delay. This is working fine. Tested on Operating System: Ubuntu 18.04.6 LTS Kernel: Linux 4.15.0-162-generic

iansan5653 commented 2 years ago

Great! I'll have this fix in the next release then.