search

iansan5653 / open-mcr

:pencil: Exam bubble sheet scorer. Created with OpenCV and Python.
GNU General Public License v3.0
160 stars 54 forks source link

I could not get the windows build command to work.... #81

Open gutow opened 2 years ago

gutow commented 2 years ago

I think something is missing from the described setup. I can get the following build command to work on Windows, but not the full one described in the build_instructions.md:

pyinstaller -p src --clean --onefile --add-data="src;." -y -w --icon=src/assets/icon.ico --name=open-mcr src/main_gui.py

This, of course, just yields an .exe file not an installer.

As I am not really a Windows user, I am not sure how important not having an installer is. For my use cases just getting the .exe is fine.

gutow commented 2 years ago

The issue may simply be that NSIS may not install properly on the machines I have access to. Is it necessary?

gutow commented 2 years ago

Maybe just change the instructions to two steps: 1. create the .exe; 2. create installer if desired.

iansan5653 commented 2 years ago

The issue may simply be that NSIS may not install properly on the machines I have access to. Is it necessary?

Yes, NSIS is necessary to build the installer exe file.

Maybe just change the instructions to two steps: 1. create the .exe; 2. create installer if desired.

I think that makes sense :+1: