search

iansinnott / jstz

🌐Timezone detection for JavaScript
Other
175 stars 33 forks source link

feat: typescript define file. #3

Closed wujun4code closed 7 years ago

iansinnott commented 7 years ago

Awesome, thanks @wujun4code

wujun4code commented 7 years ago

@iansinnott thanks for your awesome works. This lib help me a lot.

wujun4code commented 7 years ago

and could you publish it to npm? thanks.

iansinnott commented 7 years ago

Ah, yes! Forgot about that. 1.0.8 is published :)

wujun4code commented 7 years ago

Thanks again.

Yours.

silviogutierrez commented 7 years ago

Hi there,

Just a headed up, this typings file will break if you're using noImplicitAny as an option.

name() needs a return type annotation. So 

 class TimeZone {
     name(): string;
 }

Hope that helps,

Silvio