search

iansinnott / react-static-boilerplate

A boilerplate for building static sites with Webpack 2, React and React Router
107 stars 16 forks source link

Page titles not showing #11

Open bellizio opened 8 years ago

bellizio commented 8 years ago

First off, thank you for developing this! I've been trying to wrap my head around React client vs server side rendering (w/r/t static sites) for days now and this app is certainly a helpful resource.

One question though: Is there a way to get the corresponding page titles for the home and about pages to show when running the development server?

I see it is currently hardcoded in server.js.

iansinnott commented 8 years ago

Thanks @bellizio, I'm glad you're finding use in this. I've become somewhat obsessed with the benefits of rendering sites in this way, since it gives most (if not all) of the benefits of server side rendering without the need for a server.

This issue brings to mind a bug I've seen where my titles aren't rendering at all (even in prod). I've opened a separate issue about that here https://github.com/iansinnott/react-static-webpack-plugin/issues/9.

This is a good idea for an enhancement which could be added to this repo.