search

iansinnott / react-string-replace

A simple way to safely do string replacement with React components
MIT License
652 stars 56 forks source link

Added working version, updated readme, added tests. #11

Closed pejrak closed 5 years ago

pejrak commented 7 years ago

Resolves #6 , but may be introducing breaking changes compared to the previous package versions, which depended on the index being the second argument of replacer function.

iansinnott commented 7 years ago

Awesome! Thanks @pejrak. You're right about the index so this will need to be released as a new major version, which is totally fine.

iansinnott commented 7 years ago

@pejrak you feeling good about this one? Maybe we release 1.0 with these changes?

pejrak commented 7 years ago

@iansinnott This is good from functionality stand-point, have been using it in a project since adding. The readme should be good, the only thing I did not fully check is the full example with node server. Are you able to execute that?

iansinnott commented 7 years ago

@pejrak ah, thanks for the reminder. I will look into that and fix it as need be

rpearce commented 5 years ago

Doesn't look like this has any movement, but I solved the same problem today and have this functionality at https://github.com/rpearce/flexible-string-replace

iansinnott commented 5 years ago

Thanks @rpearce. Yeah this one seems to have fallen though the cracks. Going to close it out now as it's two years old

rpearce commented 5 years ago

Thanks @iansinnott . @pejrak, if you'd like to be added as a contributor on https://github.com/rpearce/flexible-string-replace, let me know, as your alternative solution & mine were almost identical, and if you still have this problem, perhaps we can iterate there together.