chore(dependencies): remove lodash's pre-method packages

iansinnott / react-string-replace

A simple way to safely do string replacement with React components

MIT License

652 stars 56 forks source link

chore(dependencies): remove lodash's pre-method packages #27

Closed geminiyellow closed 7 years ago

geminiyellow commented 7 years ago

Depending directly on lodash packages isn't supported by lodash anymore.

Close #26

iansinnott commented 7 years ago

Awesome, thanks for the PR. Does this mean we need to upgrade to lodash 5 or is it fine to stay on 4.x?

geminiyellow commented 7 years ago

@iansinnott thanks for your great work.

still safe before lodash 5 release. 😈

but you see, when i use webpack, the pre method package cannot be tree shake very well, because others packages use lodash or lodash-es.

geminiyellow commented 7 years ago

@iansinnott

and comment from @jdalton in lodash/lodash-webpack-plugin/issues/101

@jdalton commented on 17 Mar

That would require folks having both packages which is an unknown. I'm also not continuing the individual packages beyond v4 so not wanting to put anymore time into them feature wise.

iansinnott commented 7 years ago

Sounds good to me. v0.4.1