Open ianstormtaylor opened 6 years ago
We should not ignore the explicit conventions and signature of onClick
.
Also... I think this is a good case for TypeScript / Flow definitions!
@lxe can you explain? I'm not sure I understand what you mean. Thanks!
Right now, the convenience transforms are "smart" in that if you do:
It will fail because it's actually being called as
increment(event)
. Instead you have to write it as:But this is such a common use case that it might be nice to either ignore
Event
objects specifically, or just ignore anything that isn't a "valid" value.It's also easy to forget this, because
onClick={toggle}
oronClick={clear}
works since they don't care about the event argument in the first place.