🐞 Bug: German Keyboard backtick isn't recognized in onChange event; crashes editor when using placeholder - Githubissues

ianstormtaylor / slate

A completely customizable framework for building rich text editors. (Currently in beta.)

http://slatejs.org

MIT License

30.02k stars 3.26k forks source link

🐞 Bug: German Keyboard backtick isn't recognized in onChange event; crashes editor when using placeholder #4001

Open marcusellison opened 4 years ago

marcusellison commented 4 years ago

Do you want to request a feature or report a bug?

🐞 Bug

What's the current behavior?

The first keypress of a german backtic fails to register an onChange event which creates different slate and dom points.

From sandbox: https://codesandbox.io/s/slate-reproductions-forked-m8qpg?file=/package.json

delete default text until placeholder displays
make sure MacOS german keyboard is enabled
type a backtick (on my mac u.s. keyboard this is the "=" key)
then type any other character

Editor crashes with error Cannot resolve a Slate point from DOM point: [object Text],1

This can also be reproduced in slate.js examples

Slate: 0.59.0 Browser: Chrome Version 86.0.4240.198 (Official Build) (x86_64) OS: Mac 11.01

What's the expected behavior?

The first instance of typing a german backtick should register an onChange event
The editor should not crash when placeholder is enabled.

PibeG commented 3 years ago

Seems like #3437 would solve this issue.