slate-react / Editable / min-height-style

ianstormtaylor / slate

A completely customizable framework for building rich text editors. (Currently in beta.)

http://slatejs.org

MIT License

30.02k stars 3.26k forks source link

slate-react / Editable / min-height-style #4233

Open schwamic opened 3 years ago

schwamic commented 3 years ago

Description Hi! After updating to v0.62, I noticed, that the editors min-height doesn't fit to my configured styling. I think this is because of the style="min-height: 28px" in the Editable component, therefore the style-prop overwrites my class-styling... So if this is not absolutely necessary, it would be better to remove this styling so that an !import is not necessary.

Screenshots

Environment

"slate": "0.62.0",
"slate-history": "0.62.0",
"slate-react": "0.62.0",

santialbo commented 3 years ago

I'm also afected by this. I'm unable to make the Editable have a minimum height. I believe it has to do with #4190 so I'll tag @juliankrispel, maybe he can give us a hint on how we could achieve the desired result.

gfohl commented 3 years ago

https://github.com/ianstormtaylor/slate/issues/4314#issuecomment-861691232