search

ianstormtaylor / slate

A completely customizable framework for building rich text editors. (Currently in beta.)
http://slatejs.org
MIT License
30.02k stars 3.26k forks source link

Cost effective lodash #5617

Open nike1v opened 8 months ago

nike1v commented 8 months ago

Problem I'm investigating my current project to minimize the bundle size and how much data used for people to load, the only library I have in package that uses ALL lodash library as a package is slate.

Solution I'd like you to change all lodah imports to splitted modules (they are done not for fun). There are only 23 places where it is used, so it'll be quick fix.

Alternatives A clear and concise description of any alternative solutions or features you've considered.

Context If you want me to help you with this, so all slate packages will use effective version of lodash, where used, I can do this via PR. Just let me know, thanks!

dylans commented 8 months ago

@nike1v I'm happy to review and land a PR for this change.

christianhg commented 4 months ago

It looks like this is fixed in https://github.com/ianstormtaylor/slate/pull/4245.

jamesremuscat commented 1 month ago

It looks like this is fixed in #4245.

That PR was merged nearly three years before OP opened this issue...