search

ianstormtaylor / slate

A completely customizable framework for building rich text editors. (Currently in beta.)
http://slatejs.org
MIT License
29.71k stars 3.24k forks source link

Meta+` doesn't work #690

Closed AlexeiAndreev closed 7 years ago

AlexeiAndreev commented 7 years ago

if (event.which != 192 || !event.metaKey) return

This line didn't work for me. I was testing this on a Mac in Chrome. Everything else worked fine, and when I replaced "192" with anything else, it worked too. My guess is that Chrome doesn't pass this particular key combination through.

ianstormtaylor commented 7 years ago

Ah, good catch @AlexeiAndreev! I think you're right. I'd be happy to merge a pull request that changed that hotkey to being control-` instead if you're down to make it! Thanks!

ianstormtaylor commented 7 years ago

Fixed now!

potatopotaro commented 6 years ago

Just a heads up, Meta + ` is still in the instructions/Documentation for: https://docs.slatejs.org/walkthroughs/defining-custom-block-nodes Which isn't detected, on Chrome or Safari.