search

ianstormtaylor / slate

A completely customizable framework for building rich text editors. (Currently in beta.)
http://slatejs.org
MIT License
29.71k stars 3.24k forks source link

Link example: button is off when it shouldn't be #758

Closed AlexeiAndreev closed 7 years ago

AlexeiAndreev commented 7 years ago

http://slatejs.org/#/links If you position the cursor at the end of the link, the button is not active. (Note that for similar sections, like bold/italics the corresponding button would be active.) If you type something, the link is extended, which is inconsistent with the button state.

I think you could resolve this issue either way. If the button was shown active, then it's at least consistent with other buttons. If the button was inactive and typing at the end didn't expand the text, that's would be consistent with other editors, like Google Docs.

SmilinBrian commented 7 years ago

Fixed by other changes?

I can't reproduce this bug using Slate 0.24.0 code (September 12, 2017) with Mac Google Chrome Version 61.0.3163.79.

ianstormtaylor commented 7 years ago

@SmilinBrian thanks, yup this is fixed!