Rename CommonJS bundle so as to be compatible with React Native

ianstormtaylor / superstruct

A simple and composable way to validate data in JavaScript (and TypeScript).

https://docs.superstructjs.org

MIT License

7.02k stars 224 forks source link

Rename CommonJS bundle so as to be compatible with React Native #1086

Closed steveluscher closed 2 years ago

steveluscher commented 2 years ago

Fixes #1085. Read more about the problem statement there.

Summary of changes:

Tests now run against the raw Typescript source. This was necessary because Mocha is awful and renaming the cjs bundle caused the entire test system to fall apart. The one I put in place is faster, and unlocks watch mode (yarn test --watch)
Renamed CommonJS bundle to cjs.js

steveluscher commented 2 years ago

Hey @ianstormtaylor, do you have a moment to smash this in and do a release? I'd like to release and announce the Solana React Native SDK but this is the last thing preventing me from giving people a good ‘Quick Start’ experience without extra configuration.

steveluscher commented 2 years ago

Pretty please? I really want to be able to remove this patch as a line in my Getting Started README :)

amaranth commented 2 years ago

Why does this also change the test setup and all the tests?

steveluscher commented 2 years ago

I made this PR so long ago that the only thing I remember about the changes to the test system is what I wrote in the PR summary itself.

ianstormtaylor commented 2 years ago

Hey @steveluscher, very sorry for the delay here. Thank you for putting this together, and makes sense to test directly from source.

ianstormtaylor commented 2 years ago

Sorry I should have looked more closely, but I've reverted this change. This is an upstream issue (.cjs and .mjs files should be recognized by Metro) and it looks like it has been fixed upstream.

steveluscher commented 2 years ago

Haha. True. Since I made this change, Metro got its shit together. Thanks anyway!