iantrich / restriction-card

🔒 Apply restrictions to Lovelace cards
MIT License
254 stars 22 forks source link

Overlay in 1.2.8 still has some issues #93

Closed alexruffell closed 1 year ago

alexruffell commented 1 year ago

Checklist:

Release with the issue: 1.2.8

Last working release (if known): Several versions back, no idea on version number Browser and Operating System:

Description of problem:

In the previous version immediately before 1.2.8 the overlay showed correctly over the toggle however if I opened a camera and enlarged the window, the overlay was now shown over the camera feed while it should have been hidden by the overlayed camera feed window. After the 1.2.8 update, the overlay no longer shows on the camera feed however it now shows under the toggle rather than over the toggle.

See image below:

image

The tiny bit of red on the bottom two toggles is the lock now hidden by the toggle.

Javascript errors shown in the web inspector (if applicable):

Additional information:

ToniCifre commented 1 year ago

I have the same error. As I have seen, the 'overlay' remains below the 'card'. I'm not sure if it generates other errors, but adding 'z-index: 1' to 'overlay' solves the error.

ildar170975 commented 1 year ago

Not sure that using z-index is a proper way in a long-time perspective... Probably the whole "overlay" element should be moved in DOM tree on a higher z-level.

arboeh commented 1 year ago

Same for me. z-index seems to be a workaround.

seanosteen commented 1 year ago

Woo Hoo! Update v.1.2.9 and z-index adjustments removed, The overlay issue appears to be resolved on my instance. Thank you!

alexruffell commented 1 year ago

1.2.9 indeed fixed the issue. The lock no longer appears under the toggle "knob" and also doesn't get superimposed on a camera feed that overlays (when maximized) the card using the restriction. Thanks for the fix!