iantrich / roku-card

📺 Roku Remote Card
MIT License
118 stars 41 forks source link

core-2021.11.0b0 seems to have broken the roku card #67

Closed arlynxyu closed 2 years ago

arlynxyu commented 2 years ago

roku card hey there i just updated to core-2021.11.0b0 yesterday and it seems to have busted the roku card for some reason? none of the default icons show up all though when hover over them there is a shadow

iantrich commented 2 years ago

Looks like the button has changed in what values are passed in. https://github.com/home-assistant/frontend/commit/0c940be5fb002f7df938055997d2be71d6e50903#diff-b7749fac30d4d29a769a04d77d9e72093cfdfecd6e325fba66649575229bde9c

I'll look to fix it soon.

DTTerastar commented 2 years ago

Still broke in 2021.11.0b4

firestrife23 commented 2 years ago

The issue persist with 2021.11.0 release

benblb commented 2 years ago

2021.11.0, same here. PS awesome card and I use it all the time!

OverZealous commented 2 years ago

If it helps any, the same issue happened to the mini-media-player card.

Their fix looks pretty simple, which you can see in this PR.

iantrich commented 2 years ago

Lost my dev environment and couldn't dedicate much time to fixing that and properly testing a fix. Here's a pre-release to try: https://github.com/iantrich/roku-card/releases/tag/1.2.3

arlynxyu commented 2 years ago

fix does not fix it for me, neither does the update pushed to hacs

JBassett commented 2 years ago

Lost my dev environment and couldn't dedicate much time to fixing that and properly testing a fix. Here's a pre-release to try: https://github.com/iantrich/roku-card/releases/tag/1.2.3

This fixed it for me, thanks.

iantrich commented 2 years ago

fix does not fix it for me, neither does the update pushed to hacs

Did you clear your browser cache?

arlynxyu commented 2 years ago

no, i'll give that a shot, apologies

firestrife23 commented 2 years ago

Lost my dev environment and couldn't dedicate much time to fixing that and properly testing a fix. Here's a pre-release to try: https://github.com/iantrich/roku-card/releases/tag/1.2.3

It's working!