search

ianwalter / codemirror-mode-elixir

A CodeMirror mode for the Elixir language
https://codemirror-mode-elixir.optick.io
MIT License
22 stars 5 forks source link

Make codemirror a peerDependency #3

Closed pascalw closed 6 years ago

pascalw commented 6 years ago

Hey @ianwalter thanks for making this codemirror mode!

I'm using it with Webpack and ran into the issue that Webpack was including two versions of codemirror into my build, because this projects specifies codemirror as a direct dependency.

This PR makes codemirror a peerDependency. I've updated the README to reflect that codemirror itself should be installed separately. I've left the version specifier as it was, which makes this mode compatible with any version of codemirror > 5.20.2.

ianwalter commented 6 years ago

Thanks!

ianwalter commented 6 years ago

Should be released as v1.1.2. Let me know if you encounter any issues.

pascalw commented 6 years ago

Works great, thanks! 👍