search

ianwangeeen / pe

0 stars 0 forks source link

Absence of trim(), leading to invalid "get" response #6

Open ianwangeeen opened 3 years ago

ianwangeeen commented 3 years ago

image.png an extra space(a common error for fast typists using the app) creates an unwanted response

soc-pe-bot commented 3 years ago

Team's Response

Need to add trim() for the arguments

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Able to create shelf with leading whitespace but unable to delete it

Steps to reproduce:

  1. Create shelf with name " Potato"
  2. Delete shelf with name " Potato"

Expected: Able to delete " Potato", since the message tells me that shelf with " Potato" has been created.

Actual: Shelf with name " Potato" cannot be found.

image.png

Edit: Realised that " Potato" was created as "Potato", so I could delete it by deleting "Potato". However, I think the message Shelf " Potato" has been created is very misleading, since the name here includes the leading whitespace.

[original: nus-cs2113-AY2122S1/pe-interim#2787] [original labels: severity.High type.FunctionalityBug]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

Can use "trim()" in the parser so that all the arguments are trimmed first before passing on to command or model

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]