ianwhite / resources_controller

resources_controller rails plugin: rc makes RESTful controllers fun
MIT License
79 stars 21 forks source link

Update resources_controller (rc_rails gem) to be Rails 5.x compatible [ ruby, rails ] #12

Closed jlsync closed 7 years ago

jlsync commented 7 years ago

Hi, this is a meta-issue looking for someone to update this gem.

I've posted a small bounty here https://www.bountysource.com/issues/46305651-update-resources_controller-rc_rails-gem-to-be-rails-5-x-compatible - rails - ruby - gem

Update rc_rails gem to be Rails 5 compatible

The resources_controller / rc_rails gem by @ianwhite from https://github.com/ianwhite/resources_controller needs to be updated to work with Rails 5.1

Rough todo list:

  1. fork git repository

  2. update code. sub tasks include:

    • [x] remove/replace use of alias_method_chain, hide_method and other deprecated method calls
    • [x] update to current ActiveRecord finder syntax and methods
    • [x] update default actions to be compatible with rails' strong paramaters
      • e.g. self.resource = new_resource self.send("#{resource_name}_params")
    • [x] must work with rails 5.1.x with no deprecated method warnings
      • [x] update tests and rspec version
      • all existing tests need to pass
    • [x] must work with ruby 2.4.1 with no deprecated method warnings
    • [x] all existing gem features need to work, inlcuding:
      • deeply nested resources
      • child and/or parent singluar resource when nested
      • route helpers
      • custom methods
      • custom finders
      • map_enclosing_resource
      • resource_path: in config/routes.rb
    • [ ] update readme and gem documentation where required
  1. submit pull request back to this repo

Fake or Spam reponses to this issue will be deleted

jlsync commented 7 years ago

This issue and small bounty, just FYI: Forkers and contributers: @ianwhite @econsultancy @jemmyw @tomtt @revolutionhealth @sinsoku @rst @e-accent @HomeStayTravel @Alliants @LiquidPlanner @ideeli @vladvinnikov @yyyc514 @aughr @mocoso @tomstuart @reinh @tpope @rst @paolodona

Please mention/pass-on to anyone who might like to work on this.

jlsync commented 7 years ago

This work now has been mostly done. My updates are here https://github.com/jlsync/resources_controller It seems to work with Rails 5.0.8, 5.1.1, 5.1.2rc1 okay, and probably 4.2. I am closing this issue (because it's linked to bountysource.com - please don't reopen).

ianwhite commented 7 years ago

Amazing work Jason!