search

ianwijma / stare-till-they-grow

Stare in the souls of your plants & animals!
https://www.curseforge.com/minecraft/mc-mods/stare-till-they-grow
Other
1 stars 1 forks source link

Reference fixes #34

Closed aeonic-dev closed 2 years ago

aeonic-dev commented 2 years ago

This PR fixes references to Minecraft#getInstance in common code with a full rewrite of PlayerEventHandlers (now ClientTickEventHandlers), using static methods and the @EventBusSubscriber notation to ensure it's only loaded on the client. We also move config checks for ActionTypes to the ActionType class for simplicity and replace the previously static config values with instance fields.

Sponsored (unexpectedly) by the Modding Inquisition.

ianwijma commented 2 years ago

Thank you 2 so much for this PR @Matyrobbrt and @aeonic-dev! I will review and merge this PR tonight or tomorrow before I start working on the 1.19 upgrade.

Again, thank you 2 so much!

aeonic-dev commented 2 years ago

Great to hear from you! No problem, we're happy to help. Thank you for your work and for keeping this mod open source!

aeonic-dev commented 2 years ago

Happy to help man! I do have a few other changes I want to make that I took note of, but to make your job easier I'll wait till there's a more solid 1.19 branch before I make another PR. Thanks again for your work!