search

ianwremmel / extend-error

Easily define custom error types in Node.js
MIT License
0 stars 0 forks source link

Bug: Use semantic versioning #7

Open jd-carroll opened 7 years ago

jd-carroll commented 7 years ago

This repo does not follow semantic versioning and has not published a release in a significant amount of time. This makes it impossible for external consumers to reliably depend on this project.

Please start using proper semantic versioning. ciscospark/spark-js-sdk#476

ianwremmel commented 7 years ago

Hi @jd-carroll. This repo is a fork from the original extend-error (which controls the npm package name). As such, it has not been published to npm. I'd hoped my PR would be merged, but it looks like at this point the better option is going to be getting https://github.com/ciscospark/spark-js-sdk/issues/114 prioritized and deprecating this repo.

jd-carroll commented 7 years ago

Very good point, I didn't think of that... If there is any way I/we can help please let me know. I can have someone from our team put together a PR if you would be open to that.

ianwremmel commented 7 years ago

@jd-carroll just wanted to keep you in the loop: I think I've worked out how to remove extend-error entirely and I hope to have a solution deployed sometime next week.

ianwremmel commented 7 years ago

@jd-carroll extend-error has been removed from the sdk so this should no longer be an issue. I'll be replacing the code in this repo with a README that says to use es6 classes and/or babel instead of extend-error.

jd-carroll commented 7 years ago

@ianwremmel - Thanks!!!

On Mon, Mar 27, 2017 at 3:24 PM Ian Remmel notifications@github.com wrote:

@jd-carroll https://github.com/jd-carroll extend-error has been removed from the sdk so this should no longer be an issue. I'll be replacing the code in this repo with a README that says to use es6 classes and/or babel instead of extend-error.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/ianwremmel/extend-error/issues/7#issuecomment-289529550, or mute the thread https://github.com/notifications/unsubscribe-auth/ABzGqLiKwnMxMNPxzwQ02L2GSnwrZzh9ks5rp_XIgaJpZM4MXRfY .