search

ianyepan / vscode-dark-plus-emacs-theme

An accurate port of the default Visual Studio Code Dark+ theme for Emacs
GNU General Public License v3.0
174 stars 17 forks source link

Add support for emacs 27+ tabs #13

Closed ghost closed 3 years ago

ghost commented 3 years ago

Emacs 27 tabs/tab-line look bad without explicit styling. Centaur tabs also makes use of the native tabs and looks bad in 27+ without support. Faces are: tab-line tab-bar tab-bar-tab tab-bar-tab-inactive

ianyepan commented 3 years ago

Support added in latest commit. Feel free to reopen if you see anything that could be improved.

ghost commented 3 years ago

Looks like tab-line is needed as well. I still have a light gray background for the part of the tab-line that doesn't have any tabs.

ianyepan commented 3 years ago

Hi @dm19 thanks for getting back. Do you mind attaching a screenshot of the effects of "tab-line"?

ghost commented 3 years ago

No problem.

No customization: doom-tabs-2 doom-tab-3

Customized tab-line (just realized that's not the right color to match vscode, but still shows the change): doom-tabs-1

ianyepan commented 3 years ago

I just added faces for tab-line too. Let me know if this is working as expected!

brownts commented 1 year ago

I ran across a few additional face configurations that are missing from 27.x as well as 28.x for tab-line and should be configured differently (to be useful) from their defaults:

tab-line-tab-faces tab-line-tab-faces-2

ianyepan commented 1 year ago

If you could provide a pull request, I'd be more than happy to merge it! Thanks.