search

ianyepan / vscode-dark-plus-emacs-theme

An accurate port of the default Visual Studio Code Dark+ theme for Emacs
GNU General Public License v3.0
174 stars 17 forks source link

Customization options #16

Closed Murgalha closed 3 years ago

Murgalha commented 3 years ago

Hello,

I have added a few customization options on the theme, based on others that have that style, such as Solarized. As an example, I added dark-plus-box-org-todo to remove the border square on the todo keyword (default values are set to keep the theme as-is). Are you interested in these options? Can I make a PR?

Changes: https://github.com/Murgalha/vscode-dark-plus-emacs-theme/commit/e4b5101b57ed66c17b2d1f1bf7def60e4a278926

ianyepan commented 3 years ago

Absolutely, PRs welcome!

ianyepan commented 3 years ago

@Murgalha Just one issue: could you rename the variable names to start with "vscode-dark-plus..." instead of just "dark-plus..."? Otherwise it won't pass some linting tests.

Murgalha commented 3 years ago

I changed the variable names and updated the README as well. Also opened the PR #17

ianyepan commented 3 years ago

Awesome, thanks for the work!