search

ianyepan / vscode-dark-plus-emacs-theme

An accurate port of the default Visual Studio Code Dark+ theme for Emacs
GNU General Public License v3.0
174 stars 17 forks source link

Inconsistent header-line border color in lsp-mode breadcrumb #23

Closed YongJieYongJie closed 3 years ago

YongJieYongJie commented 3 years ago

Issue:

In the header line, the border color for the words common, loggers, loggers.go and the character > is different from the color of the rest of the border (see top-left of screenshot below). FYI, the header is the breadcrumb from lsp-mode.

Question: Is there a way to have a consistent border color across the header line?

image

Same situation occurs for the built-in manual:

image

Expected behavior / look-and-feel:

Something that looks more natural might be like the Zenburn theme:

image

YongJieYongJie commented 3 years ago

Update: I found this commit https://github.com/ianpan870102/vscode-dark-plus-emacs-theme/commit/1e694e1704e6bf55726040953ed5cf703f02c16d, will it help to solve the above issue?

ianyepan commented 3 years ago

Update: I found this commit 1e694e1, will it help to solve the above issue?

I've made header-line look exactly like the mode-line, without inheriting it. This simultaneously fixes #23 and #10.

ianyepan commented 3 years ago

Wait, mode-line's background is way too much. I'll make it dark grey...

ianyepan commented 3 years ago

Looks good to me now

image

YongJieYongJie commented 3 years ago

@ianpan870102 Thanks for the amazingly fast fix! (And also the theme in the first place! :100: )