search

ianyepan / vscode-dark-plus-emacs-theme

An accurate port of the default Visual Studio Code Dark+ theme for Emacs
GNU General Public License v3.0
174 stars 17 forks source link

Add config to helm-ls-git-added-modified-face #31

Open zw963 opened 2 years ago

zw963 commented 2 years ago

Please check following discuss:

https://github.com/emacs-helm/helm/discussions/2548

Following blue color is really hard to read.

image

In fact, many other themes add config to this, e.g. leuven, color-theme-sanityinc-tomorrow etc.

e.g. it really nice to use same color for M and AM, like sanityinc-tomorrow.

image

Or monokai theme

image

i really love this vscode emacs theme, except missing this config.

thank you.

zw963 commented 1 year ago

Helm config it default face to a better color, this issue get fixed now, although, make this configable in theme still isn't a bad idea.

ianyepan commented 1 year ago

Thanks @zw963 for bringing this up! I'm glad that the issue is fixed by Helm config. Personally, I use ivy/counsel instead of Helm, so I can't say I'm familiar with the issue.

...make this configurable in theme still isn't a bad idea.

If you could provide a PR, I'd be more than happy to merge it. Cheers!