search

ianyepan / vscode-dark-plus-emacs-theme

An accurate port of the default Visual Studio Code Dark+ theme for Emacs
GNU General Public License v3.0
174 stars 17 forks source link

helm-selection #7

Closed kvaneesh closed 4 years ago

kvaneesh commented 4 years ago

Can we make the highlight better? With the current values, I was finding it difficult to locate the current line.

ianyepan commented 4 years ago

Hi and thanks for the feedback @kvaneesh , do you mind posting a screenshot to illustrate the problem?

kvaneesh commented 4 years ago

(helm-selection ((,class (:background ,bg-hl :underline nil)))) (helm-selection-line ((,class (:background ,bg-hl))))

That change made it better

kvaneesh commented 4 years ago

image

kvaneesh commented 4 years ago

with the changes suggested image

ianyepan commented 4 years ago

Thanks man! It was indeed meant to be bg-hl, I must have missed it when renaming the variables. I'll push a commit to update this change

ianyepan commented 4 years ago

This commit https://github.com/ianpan870102/vscode-dark-plus-emacs-theme/commit/9b0089670244d2d60f2eae4287e15cc8a3310c29 should fix the issue