search

ianyh / Amethyst

Automatic tiling window manager for macOS à la xmonad.
https://ianyh.com/amethyst/
MIT License
14.84k stars 487 forks source link

iterm2 tiling creates margins with none set #1036

Open Isweet opened 4 years ago

Isweet commented 4 years ago

Describe the bug When I tile iterm2 windows, there is a vertical margin despite the Amethyst settings being set to no window margins and no screen padding. Other OSX spaces with other applications appropriately tile with no margins or padding.

Applications: iterm2

To Reproduce Move to a new OSX space, launch iterm2, press Cmd+N twice to open two new windows. It seems to happen no matter Amethyst layout (though, obviously, not full screen since you need multiple windows to notice vertical margin).

Expected behavior No vertical margin between windows.

Screenshots

Screen Shot 2020-07-25 at 8 20 34 PM Screen Shot 2020-07-25 at 8 27 04 PM Screen Shot 2020-07-25 at 8 27 29 PM

Versions:

Debug Info

$ /Applications/Amethyst.app/Contents/MacOS/Amethyst --debug-info
Version: 0.15.3 (88)

OS version: Version 10.15.3 (Build 19D76)

Has permissions: false

Screens:
    (0.0, 0.0, 1440.0, 900.0) [(0.0, 0.0, 1440.0, 900.0)]

Manageable applications:
    ViewBridgeAuxiliary (com.apple.ViewBridgeAuxiliary)
    Mail (com.apple.mail)
    Control Strip (com.apple.controlstrip)
    talagent (com.apple.talagent)
    ViewBridgeAuxiliary (com.apple.ViewBridgeAuxiliary)
    EmojiFunctionRowIM (com.apple.inputmethod.EmojiFunctionRowItem)
    AppSSOAgent (com.apple.AppSSOAgent)
    QuickLookUIService (PID 442) (com.apple.quicklook.QuickLookUIService)
    Finder (com.apple.finder)
    studentd (com.apple.studentd)
    SiriNCService (com.apple.SiriNCService)
    coreautha (com.apple.LocalAuthentication.UIAgent)
    Slack (com.tinyspeck.slackmacgap)
    com.apple.appkit.xpc.openAndSavePanelService (Mail) (com.apple.appkit.xpc.openAndSavePanelService)
    QuickLookUIService (com.apple.appkit.xpc.openAndSavePanelService (Mail)) (com.apple.quicklook.QuickLookUIService)
    Google Chrome (com.google.Chrome)
    com.apple.appkit.xpc.openAndSavePanelService (Google Chrome) (com.apple.appkit.xpc.openAndSavePanelService)
    QuickLookUIService (com.apple.appkit.xpc.openAndSavePanelService (Google Chrome)) (com.apple.quicklook.QuickLookUIService)
    LookupViewService (Mail) (com.apple.LookupViewService)
    com.apple.appkit.xpc.openAndSavePanelService (Slack) (com.apple.appkit.xpc.openAndSavePanelService)
    QuickLookUIService (com.apple.appkit.xpc.openAndSavePanelService (Slack)) (com.apple.quicklook.QuickLookUIService)
    LookupViewService (Google Chrome) (com.apple.LookupViewService)
    zoom.us (us.zoom.xos)
    Preview (com.apple.Preview)
    Music (com.apple.Music)
    VisualizerService (Music) (com.apple.Music.VisualizerService)
    com.apple.appkit.xpc.openAndSavePanelService (Music) (com.apple.appkit.xpc.openAndSavePanelService)
    QuickLookUIService (com.apple.appkit.xpc.openAndSavePanelService (Music)) (com.apple.quicklook.QuickLookUIService)
    iTerm2 (com.googlecode.iterm2)
    DocumentPopoverViewService (Preview) (com.apple.appkit.xpc.documentPopoverViewService)
    QuickLookUIService (DocumentPopoverViewService (Preview)) (com.apple.quicklook.QuickLookUIService)

Configuration:
focus-follows-mouse: 0
window-minimum-height: 0
screen-padding-right: 0
ignore-menu-bar: 0
follow-space-thrown-windows: 1
floating-is-blacklist: 1
restore-layouts-on-launch: 1
screen-padding-bottom: 0
enables-layout-hud-on-space-change: 1
window-margins: 0
new-windows-to-main: 0
float-small-windows: 0
enables-layout-hud: 1
layouts: (
    tall,
    wide,
    fullscreen,
    column,
    bsp
)
screen-padding-top: 0
mouse-follows-focus: 0
floating: (
)
debug-layout-info: 0
mod2: (
    option,
    shift,
    control
)
window-resize-step: 5
use-canary-build: 0
window-minimum-width: 0
screen-padding-left: 0
window-margin-size: 5
mod1: (
    option,
    shift
)

Additional context This could very well be an issue of a rogue setting inside of iterm2, but I've checked them all out and I can't seem to find it. My gut says that somehow iterm2 is declaring to the window manager somehow that its windows are larger than they actually are.

mdouglass commented 4 years ago

I believe this is related to a setting in iTerm - in Preferences, go to the Advanced tab, scroll down to Windows and look for "Terminal windows resize smoothly" -- set that to Yes and that should fix the issue.

Isweet commented 4 years ago

That seems to have fixed it. Maybe add a note somewhere? I'm not sure where is the best place.

Leaving open for now, in case you want to add something to documentation. Feel free to close.