ianyh / Amethyst

Automatic tiling window manager for macOS à la xmonad.
https://ianyh.com/amethyst/
MIT License
14.81k stars 487 forks source link

Float small windows not working with GoLand popups? #892

Open ivanpk opened 5 years ago

ivanpk commented 5 years ago

System

What's the problem?

Unable to float small popups in GoLand, they become tiled immediately

How can it be reproduced?

Use GoLand and call a small window popup (ctrl-G for example, to go to a line number opens a small window) - Amethyst then tiles this instead of leaving it floating. The float small windows setting is enabled as well.

If you add Goland to the automatically float applications listed setting, then the entire app floats, when I'd like only the popups not to float.

What applications are involved?

Jetbrain's GoLand

Has anything fixed it, even temporarily?

No

simonelnahas commented 5 years ago

also all "CMD + ," settings popups is not floating

justenwalker commented 4 years ago

What counts as a "small" window appears to be hard-coded: https://github.com/ianyh/Amethyst/blob/master/Amethyst/Model/Window.swift#L249 -- perhaps if this were configurable it could be used to exclude some of the GoLand pop-ups as well? I measured the GoLand pop-ups and they are a bit wider than 500px for me (779x484 px), so they don't qualify as small

luxmeter commented 1 year ago

noticed the same issue in Intellij for almost all its popups. Maybe it would be better to make all child / modal windows floating by default

ianyh commented 1 year ago

It's unfortunately not that simple. Some applications just use normal windows for their "modals," so you can't reliably differentiate them.

luxmeter commented 1 year ago

I see, but they would have a parent, wound't they? I have no clue, I just imagine that there is some kind of hierarchy. Might be beneficial to add an user option to make all child windows floating by default.

justenwalker commented 1 year ago

Or may I suggest making the max height/width user configurable, as it is still hard coded to 500px