search

ianyimi / EtherRealms

Personal Portfolio and Theme Park of Isaiah Anyimi
zays-world.vercel.app
2 stars 1 forks source link

Ona Code Review #12

Open Onariaginosa opened 2 years ago

Onariaginosa commented 2 years ago

My code review is here

Onariaginosa commented 2 years ago

For file CryptoRealms/src/Realm/properties/RealmScene/Cubes/BackgroundCubes.tsx on line 19 you write the following:

  for (let i=0; i<75; i++) {

I am curious as to what those numbers mean. Maybe add a variable giving the limit number (75) a name, so that the loop conditions seems a bit less like magic numbers.

Onariaginosa commented 2 years ago

In your README.md it seems you have the default information on how to load a specified software. If you have the time, maybe you can personalize your README.md file a bit more and add things that pertain to your project specifically.