ianyong / pe

0 stars 0 forks source link

Cannot add meetings that cross over to the next day #6

Open ianyong opened 3 years ago

ianyong commented 3 years ago

Because the TO parameter of the add command for the meeting mode does not take in a date, it is not possible to add meetings that cross over to the next day, such as from 11pm of today to 1am of tomorrow. This is a valid use case as some regional offices need to schedule meetings with the company HQ, which would take place during the timezone of the HQ.

nus-se-bot commented 3 years ago

Team's Response

These cases are very unlikely and are anomalies, as most meetings are within a day.

As such, we decided to implement the one-day constraint such that users find it convenient to specify end time.

This is done with the feedback our team received during PE-D as consideration (https://github.com/AY2021S1-CS2103T-F11-2/tp/issues/163).

Screenshot 2020-11-17 at 5.25.07 PM.png

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: Thanks for explaining the team's thoughts behind the design of this feature! I disagree with the team's assessment though.

These cases are very unlikely and are anomalies, as most meetings are within a day.

I have given the following scenario in the original bug report where such cases are likely to occur:

This is a valid use case as some regional offices need to schedule meetings with the company HQ, which would take place during the timezone of the HQ.

For a product manager in a regional office who has to schedule meetings with the company HQ where the HQ office hours overlap midnight local time, such a case would occur fairly frequently.

As such, we decided to implement the one-day constraint such that users find it convenient to specify end time.

This is done with the feedback our team received during PE-D as consideration (https://github.com/AY2021S1-CS2103T-F11-2/tp/issues/163).

The feedback given during PE-D only suggested for the date in the TO section to be optional, and not to remove the entire date argument. If the former approach was used instead, then this would not be an issue. Currently, it is impossible to input a meeting that crosses over to the next day even though such a case is possible in real life as mentioned above.


:question: Issue severity

Team chose [severity.Low] Originally [severity.Medium]

Reason for disagreement: severity.Low is defined as:

A flaw that is unlikely to affect normal operations of the product. Appears only in very rare situations and causes a minor inconvenience only.

If I were a product manager who has a meeting that crosses over to the next day, I would not be able to input the meeting into Productiv. Clearly, this affects the normal operations of the product, since the meeting cannot be entered and tracked.

Meanwhile, severity.Medium is defined as:

A flaw that causes occasional inconvenience to some users but they can continue to use the product.

This bug report was classified as severity.Medium because being unable to input and track the meeting is an inconvenience that occasionally occurs (whenever I have a meeting that crosses over to the next day). However, I am able to otherwise continue using the product.