search

iapetos163 / sv-sandwich-builder

Pokémon S/V Sandwich Calculator
https://birbzone.com/sandwich
Other
12 stars 1 forks source link

noHerba Option #51

Closed nayfaan closed 3 months ago

nayfaan commented 4 months ago

47 : Added option to block Herba Mystica in Creative Recipes

40 : Increased max number of Creative recipes shown

nayfaan commented 4 months ago

It looks like there's an issue with filterSandwichResults where it can't handle the case where sandwiches is empty.

I don't think I have changed anything regarding the logic for sandwiches in filterSandwichResults. The issue you mentioned should have existed in the code originally. That said, I think sandwiches shouldn't be possibly empty according to the code. Though, I suppose you could add something that will catch an empty sandwiches and throw an exception when that happens, but I think that is beyond the scope of this pull request.