iaphub / react-native-iaphub

The easiest way to implement IAP (In-app purchase) in your React Native app.
https://www.iaphub.com/
MIT License
319 stars 21 forks source link

Cycle warning module fetch #84

Closed zeikeland closed 3 years ago

zeikeland commented 3 years ago

After installing this package i always get a console Cycle warning concerning fetch.

Require cycle: node_modules/react-native/Libraries/Network/fetch.js -> node_modules/whatwg-fetch/dist/fetch.umd.js -> node_modules/react-native/Libraries/Network/fetch.js

Are anyone else seeing this warning?

iaphub commented 3 years ago

This warning is caused by react-native-fetch-polyfill, a dependency of the plugin. It seems like the warning is a bug in react-native, we were able to fix it by adding a 'hack'(see link below), weird it is not working on your side. https://github.com/iaphub/react-native-iaphub/blob/55809e5268fc999b1ce97f545a8b4ad06a9c96ac/src/index.js#L7

zeikeland commented 3 years ago

I can se the hack you mention is added to the module, but it's not working. Im running on iOS if that matters.

iaphub commented 3 years ago

What version of react native are you using?

zeikeland commented 3 years ago

Sorry for late reply, Im running version 0.64.1

iaphub commented 3 years ago

Thanks for the info @eikeland, we'll take a look at that and comment this ticket to let you know if we find a workaround (closing it in the meantime).

zeikeland commented 3 years ago

Great, thanks.