iappyx / Instrumenta

Free and open source consulting-style Powerpoint toolbar
MIT License
251 stars 20 forks source link

Some text-related functions aren't working when Text shapes are grouped #16

Closed Chouffy closed 2 years ago

Chouffy commented 2 years ago

Describe the bug Some text-related functions aren't working when Text shapes are grouped. Affected functions are:

To Reproduce Steps to reproduce the behavior:

  1. Create a Text box and add some long text inside
  2. Click on Toggle Text Wrap
  3. Change size of the shape
  4. Confirm that it works as expected
  5. Duplicate the shape
  6. Make a group out of those 2 shapes
  7. Try to use Toggle Text Wrap when selecting the group or when selecting a Text shape inside the group
  8. Get the error "No text capable shape selected."

Expected behavior Same behavior than when selecting the Text shape not in a group

Screenshots image

Desktop (please complete the following information):

iappyx commented 2 years ago

Hi Chouffy, that's right, the current code does not support this. Will look into it.

iappyx commented 2 years ago

Latest beta 1.03 now solves this for the three text functions you mentioned. Other functions could also still be improved in handling situations where shapes are grouped. Will close this issue, but other functions will be improved in next releases.

If you select one or more objects in a group it will apply the commands only to those objects. If you select a group (and no particular shapes within that group) it will apply the commands to all shapes in the group. I believe this the behavior one would expect.

Please note that I've submitted this new beta release to Microsoft Security Intelligence, as previous versions received false positive results. If false positive results come back, I will post them here.

iappyx commented 2 years ago

Now also changed the behaviour for other text functions in version 1.1. This release also improves shape handling within groups of shapes. E.g. you can now align selected shapes within a group.