search

iasonasma / seipassignment

The second assignment of SEIP
0 stars 0 forks source link

Test cases for unittesting #9

Closed iasonasma closed 4 years ago

iasonasma commented 4 years ago

Hello.

I've done the unittesting according to the second SEIP assignment. Please have a look.

iasonasma commented 4 years ago

Codecov Report

Merging #9 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master       #9   +/-   ##
=========================================
  Coverage     96.29%   96.29%           
  Complexity       29       29           
=========================================
  Files             4        4           
  Lines            54       54           
  Branches         11       11           
=========================================
  Hits             52       52           
  Misses            2        2

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 98baac5...98baac5. Read the comment docs.

iasonasma commented 4 years ago

Hey.

I've done the required changes.Please review for possible mistake.

AntonisGkortzis commented 4 years ago

@iasonasma you should pay extra attention to your commit messages, non of them is completely valid. Read again this guide

iasonasma commented 4 years ago

Hello. I've done the request changes,coverage also went to 96%. I believe my commit is now better and more detailed than before. Please request them for furthur changes.