Fix for #24 - Githubissues

iati-data-access / data-backend

GNU Affero General Public License v3.0

1 stars 0 forks source link

Fix for #24 #25

Closed simon-20 closed 8 months ago

simon-20 commented 8 months ago

This fix does two things:

first, it fixes the construction of the SQL statement so that if the reporting_organisation_type is unknown it is set to '', instead of to NULL (the NULL value was violating a DB constraint and throwing an exception)
second, it catches database IntegrityErrors, rolls back that batch, and then carries on. This should avoid the program crashing out if there are other DB constraint errors.

simon-20 commented 8 months ago

Note: the reason for truncating the exception error message in the catching of the IntegrityError exception is that the error message contains the full SQL statement, and since this is possibly updating a batch of 5000 records, the error message is huge.