iausathub / satchecker

IAU CPS SatHub tool for satellite position prediction
BSD 3-Clause "New" or "Revised" License
7 stars 1 forks source link

Verify if ecef_to_eci is correct #85

Open github-actions[bot] opened 1 month ago

github-actions[bot] commented 1 month ago

The results of this function in combination with the other coordinate system updates

for SGP4 give results similar to, but not identical to, the Skyfield results, so each

new conversion needs to be individually verified

https://github.com/iausathub/satchecker/blob/c5a9a3b0fbe274986a361d37c20d86114d8fddba/src/api/utils/coordinate_systems.py#L175


    return np.rad2deg(az), np.rad2deg(el)

# TODO: Verify if ecef_to_eci is correct
# The results of this function in combination with the other coordinate system updates
# for SGP4 give results similar to, but not identical to, the Skyfield results, so each
# new conversion needs to be individually verified
def ecef_to_eci(r_ecef: list[float], theta_gst: float) -> np.ndarray:
    """
    Convert ECEF (Earth-Centered, Earth-Fixed) coordinates to ECI (Earth-Centered