iawia002 / lux

👾 Fast and simple video download library and CLI tool written in Go
MIT License
25.97k stars 2.88k forks source link

Downloaded video and audio files are no longer automatically merged with 'ffmpeg', even when 'ffmpeg' is in the same folder/path as the downloaded video and audio files #1262

Open Pandemoniu opened 11 months ago

Pandemoniu commented 11 months ago

As of recent, it seems video and audio files downloaded using 'lux' aren't automatically merged together by 'ffmpeg', even when 'ffmpeg' is in the exact same folder/path as the downloaded video's files.

The following is the error that gets thrown after the download is complete:

Merging video parts into 魔晶猎人 第四季 第3话 欲加之罪.mp4
Downloading https://www.bilibili.com/bangumi/play/ep113803/ error:
exec: "ffmpeg": cannot run executable found relative to current directory

github.com/iawia002/lux/utils.runMergeCmd
        /Users/iawia002/go/src/github.com/iawia002/lux/utils/ffmpeg.go:17
github.com/iawia002/lux/utils.MergeFilesWithSameExtension
        /Users/iawia002/go/src/github.com/iawia002/lux/utils/ffmpeg.go:40
github.com/iawia002/lux/downloader.(*Downloader).Download
        /Users/iawia002/go/src/github.com/iawia002/lux/downloader/downloader.go:673
github.com/iawia002/lux/app.download
        /Users/iawia002/go/src/github.com/iawia002/lux/app/app.go:325
github.com/iawia002/lux/app.New.func1
        /Users/iawia002/go/src/github.com/iawia002/lux/app/app.go:247
github.com/urfave/cli/v2.(*App).RunContext
        /Users/iawia002/go/pkg/mod/github.com/urfave/cli/v2@v2.6.0/app.go:322
github.com/urfave/cli/v2.(*App).Run
        /Users/iawia002/go/pkg/mod/github.com/urfave/cli/v2@v2.6.0/app.go:224
main.main
        /Users/iawia002/go/src/github.com/iawia002/lux/main.go:13
runtime.main
        /opt/homebrew/Cellar/go/1.20.5/libexec/src/runtime/proc.go:250
runtime.goexit
        /opt/homebrew/Cellar/go/1.20.5/libexec/src/runtime/asm_amd64.s:1598

This is very inconvenient, since it leaves separate audio and video files cluttering the folder you downloaded them into that you are forced to try and merge yourself, if you can or even know how to. This is especially irksome when downloading a large quantity of videos, like from a playlist.

In the past, having 'ffmpeg' in the same folder/path you are downloading videos to was all you needed, and 'lux' (or 'annie' as it was once known) would automatically use 'ffmpeg' to merge any file parts after the download was completed. I'm opening this issue in the hopes it can be looked into and corrected so that things can return to how they once worked.

Thank you for your time.

asyncButNeverAwaits commented 9 months ago

Try version v0.17.0

https://github.com/iawia002/lux/releases/tag/v0.17.0

At version 0.17.0, no issue on merging bilibili video and audio for me

Pandemoniu commented 9 months ago

Try version v0.17.0

https://github.com/iawia002/lux/releases/tag/v0.17.0

At version 0.17.0, no issue on merging bilibili video and audio for me

Isn't that an older version?

Still, I can hold on to and try this older version next time I find myself wanting to use lux on places like bilibili, just to see if it'll work.

Mind, even if an older version does work like it's supposed to, that wouldn't be a fix to the issue going forward for newer versions.

Cola0165 commented 6 months ago

Me too.