iazarny / gitember

Gitember another git GUI client written on javafx
http://gitember.org/
84 stars 15 forks source link

HistoryCommits refactoring and UI tweaks #28

Closed MichalHecko closed 5 months ago

MichalHecko commented 6 months ago

Hi,

first think i am gonna do is tweaking a little of how commits history looks like at all. Needs a little polish here and there and i did a small code review. This is just a draft, need a little thinks to do in next days.

Few improvements of UI:

  1. Merge commit lanes column with commit messages column together
  2. Remove refs column and make ref be part of - before commit message (as a badges with icons)
  3. Make commit lanes with message column to fit the rest of table with automagically

Small example, where i am right now - not final version of course (i am gonna polish UI of commits more and more).

Screenshot from 2024-05-08 09-43-20

Code review:

  1. Make a history commit view more modular - moving to separe packages by functionalities (i.e. move to module/histry with FXML files, ...), lots of annonyous classes as lambdas or classes (handlers, factories, listeners, ...)
  2. I just start with history commit, plan is to modularize all views within separate packages consist of controllers, services, factories, helpers, data object, ...

Give me feedback what you think about it.

Be prepare for more PR after this, i.e. Lombok in all project, more refactoring how this project is organized, ...