search

ib-lundgren / flask-oauthprovider

Create a secure OAuth provider easily, powered by OAuthLib
BSD 3-Clause "New" or "Revised" License
86 stars 21 forks source link

Added MongoDB example #2

Closed ghost closed 11 years ago

ghost commented 11 years ago

A port of /demoprovider from sqlalchemy to pymongo.

ib-lundgren commented 11 years ago

Hey,

Thanks a lot for this PR. I missed that it was sent as my email filter sent the notification into my "flick through when I have a moment" list. I'll try and find some time to look into it soon =)

ghost commented 11 years ago

No problem! I'm working on MongoDB-backed website that needs to act as an OAuth provider, so I had to do the work anyway. I figured I might as well let others benefit from my efforts too. I actually found a couple more problems with my example code, so I'm going to correct those and commit them as soon as I get a moment. You should see one more commit from me in about eight hours.

ghost commented 11 years ago

Alright, fixed the errors I spotted. Should be good to go.

ib-lundgren commented 11 years ago

Nice, will give it a spin tomorrow. I've made a small change to provider so will have to make sure I don't break your example.

It would be great to chat about your experiences implementing an OAuth provider if you have time at some point.

ghost commented 11 years ago

Would be happy to. I'm on Gmail chat from around 6pm to 1am UTC most weekdays.

Thanks!

On Sun, Dec 16, 2012 at 1:45 PM, Ib Lundgren notifications@github.comwrote:

Nice, will give it a spin tomorrow. I've made a small change to provider so will have to make sure I don't break your example.

It would be great to chat about your experiences implementing an OAuth provider if you have time at some point.

— Reply to this email directly or view it on GitHubhttps://github.com/ib-lundgren/flask-oauthprovider/pull/2#issuecomment-11423376.

ib-lundgren commented 11 years ago

Looks good, I've not dug deeply into the code but ran the hmac demo against your server which worked nicely. Please revert examples/init_db.py since you don't use init_db anyway, then I'll merge.

I would have gone over it in more detail but found and fixed a great many small broken things when running my old demo. Also noticed that when kenneth pushed requests 1.0 he refactored quite a bit and broke the oauth extension so will have to push my fixes for that out at some point too...

Feel free to add some docs to the readme about running your demo if you have time, if not I'll add some in when I'm updating the ones for sql.

ghost commented 11 years ago

Alright, I updated the README.rst to include information about the MongoDB example and reverted examples/init_db.py. Should be good to go now. :-)

Thanks!

ib-lundgren commented 11 years ago

Nice work! Don't hesitate to send more PRs or open issues either here or on oauthlibs side in the future =)

ghost commented 11 years ago

Thanks! Will do.