search

ib / xarchiver

(continuation of the Xfce master branch)
GNU General Public License v2.0
171 stars 40 forks source link

Drag and Drop not working from xarchiver to thunar in wayland, but work reversed #196

Closed benyaminl closed 3 months ago

benyaminl commented 3 months ago

Hello,

I just want to report a case, I don't know whether it's part of xarchiver works or not (probably not), which I found when drag and drop on xwayland using gnome wayland broken from both xwayland based apps. (to be honest I also tried engrampa, and it yield the same result, probably wayland?)

example I open zip file, and try to drag and drop files from xarchiver to thunar. The action does give feedback on UI that we can drag and drop and + on thunar, but after drops, the files isn't extracted.

I tried running both apps using terminal, yield no errors (probably because how wayland and X having different protocol, based on https://gitlab.gnome.org/GNOME/file-roller/-/issues/4)

But the strange thing is, when I have file in thunar, drag it to xarchiver, it will automatically add the file to the existing archives. Can any of the maintainer look into this? If it's not possible because of wayland, I think it's fine., I just curious why it works only for archiving but not on extracting.

Thanks you

EDIT: https://github.com/mate-desktop/engrampa/issues/423#issuecomment-2282424777 (for some reason seems lxqt-archiver is working with drag and drop, well.... hmmm.. it's interesting)

Some videos of the files extract

https://github.com/user-attachments/assets/d587b3c9-9a40-4d89-8247-74f8a5f86f64

ib commented 3 months ago

Your assumption is correct. It is due to wayland and a missing protocol.

The XDS dnd file saving protocol is used so that the file manager tells the archiver where to extract to, i.e. the direction xarchiver -> thunar (and implicitly through the protocol also thunar -> xarchiver automatically back again). This requires the file manager to read a window property, but this is not implemented for wayland in GTK.

The other way around, i.e. file manager -> archiver, to get the list of files to add, works through a file list and does not require a special X property.

As you can read in the missing protocol link above, neither side (nor wayland or GTK) is interested in bringing back XDS dnd file saving.

benyaminl commented 3 months ago

Thanks for clarifying @ib

I will close this ticket. Hopefully in the future, there will be bridge for this, and the drag and drop keep working again, as more and more distro and WM forcing wayland by default and start droping X11

Thanks for keeping xarchiver alive.

Anyway DragDrop can be replaced or solved with same folder the file is residing, related to https://github.com/ib/xarchiver/issues/195

Not as perfect as it's, but well, it's great alternative I think (imo)