search

ibaiGorordo / ONNX-YOLOv8-Object-Detection

Python scripts performing object detection using the YOLOv8 model in ONNX.
MIT License
393 stars 101 forks source link

Added a FastAPI interface + unique numbers to all objects #5

Closed brgrp closed 1 year ago

brgrp commented 1 year ago

Hi, I extended your implementation by a rest api + minor tweeks.

ibaiGorordo commented 1 year ago

Hi, thanks for the PR.

My goal is for these repositories to be as minimal as possible. What you are trying to do is kind of a wrapper around the repository requiring additional dependencies most people would not use.

So, instead of adding these changes to this repository, I will ask you to rename your fork (or have this repository as a submodule) with the title saying something about FastAPI, and once you do that, we can modify the readme to redirect people to your repository if they want to use FastAPI.

brgrp commented 1 year ago

Hi, thanks for the fast reply. I though and still think the rest API would be a nice extention to the existing "wrappers". So users can decide whether they would use webcam, videostream or data from an api!

But if I can't convince you, I will consider your suggestion.

Would you be interested in the unique label commit https://github.com/ibaiGorordo/ONNX-YOLOv8-Object-Detection/pull/5/commits/32511ff1f7fc21aba8db3f80668856095265253c? If so, I can create a seperate PR.

Best regards