search

ibalazevic / TuckER

TuckER: Tensor Factorization for Knowledge Graph Completion
MIT License
350 stars 60 forks source link

Why is self-adversarial negative sampling unfair? #13

Closed apoorvumang closed 4 years ago

apoorvumang commented 4 years ago

You have said that 'The RotatE (Sun et al., 2019) results are reported without their self-adversarial negative sampling (see Appendix H in the original paper) for fair comparison'

What is the reason for it being unfair?

ibalazevic commented 4 years ago

Self-adversarial negative sampling in itself is a perfectly valid thing to do. However, given that it is not specific to RotatE only, it can be used with other models. Since the authors of the RotatE paper show that it increases performance and given that no other models whose results we report use it (including TuckER), we report the RotatE results without it for fair comparison.