ibarwick / firebird_fdw

A PostgreSQL foreign data wrapper (FDW) for Firebird - latest version 1.4.0 (2024-05-11)
https://sql-info.de/postgresql/firebird-fdw/index.html
Other
36 stars 8 forks source link

Cannot load extension into PostgreSQL 15 - undefined symbol: pg_atoi #29

Open mithnae opened 1 year ago

mithnae commented 1 year ago

https://git.postgresql.org/gitweb/?p=postgresql.git;a=commitdiff;h=73508475d69e90f98ebd9b7e1a5933a26a49c5e9 has removed has removed pg_atoi

As a result packaged firebird_fdw cannot be loaded into PostgreSQL 15:

postgres=# create extension firebird_fdw;
ERROR:  could not load library "/usr/pgsql-15/lib/firebird_fdw.so": /usr/pgsql-15/lib/firebird_fdw.so: undefined symbol: pg_atoi

Similar problem impacted postgis → https://trac.osgeo.org/postgis/ticket/5100 The patch provided might suggest sollution

ibarwick commented 1 year ago

I fixed this in commit 69708a644579bdfd9affe9b6e5c15a6e28c5843a. As I haven't yet managed to finalized a release with PostgreSQL 15 compatibility (will do so towards the end of the month), you are presumably attempting to load a binary compiled for an older version?

mithnae commented 1 year ago

I used Devrim's rebuild for postgresql-15 from PGDG repo. I do not know how he was able to build an older version against Postgresql-15.

I will check the source package and comment if he provided a patch himself or if the package was just not validated thoroughly before publishing.

ibarwick commented 1 year ago

Oh, interesting. That sounds like it shouldn't have happened.

ibarwick commented 1 year ago

I raised an issue: https://redmine.postgresql.org/issues/7754

ibarwick commented 1 year ago

FYI firebird_fdw 1.3.0 is now released with PostgreSQL 15 support; no PGDG packages yet, but I have created RHEL7/8 packages via Copr in case of any use:

mkgrgis commented 1 year ago

In some cases pg_strtoint64(s) can works in place of pg_atoi, see. https://github.com/petere/pguint/pull/21/files