PostgreSQL 16 support

[devrimgunduz]

Hi @ibarwick ,

V16 beta1 is out, and firebird_fdw fails to compile against it. Can you please take a look? Thanks! Devrim

/usr/lib64/ccache/clang -Wno-ignored-attributes -fno-strict-aliasing -fwrapv -fexcess-precision=standard -Xclang -no-opaque-pointers -Wno-unused-command-line-argument -Wno-compound-token-split-by-macro -O2  -I/usr/include/firebird -I. -I./ -I/usr/pgsql-16/include/server -I/usr/pgsql-16/include/internal  -D_GNU_SOURCE -I/usr/include/libxml2  -I/usr/include -flto=thin -emit-llvm -c -o src/options.bc src/options.c
src/firebird_fdw.c: In function 'firebirdPlanForeignModify':
src/firebird_fdw.c:2103:31: warning: implicit declaration of function 'bms_first_member'; did you mean 'bms_is_member'? [-Wimplicit-function-declaration]
 2103 |                 while ((col = bms_first_member(tmpset)) >= 0)
      |                               ^~~~~~~~~~~~~~~~
      |                               bms_is_member
gcc -Wall -Wmissing-prototypes -Wpointer-arith -Wdeclaration-after-statement -Werror=vla -Wendif-labels -Wmissing-format-attribute -Wimplicit-fallthrough=3 -Wcast-function-type -Wshadow=compatible-local -Wformat-security -fno-strict-aliasing -fwrapv -fexcess-precision=standard -Wno-format-truncation -Wno-stringop-truncation -g -O2 -flto=auto -ffat-lto-objects -fexceptions -g -grecord-gcc-switches -pipe -Wall -Werror=format-security -Wp,-U_FORTIFY_SOURCE,-D_FORTIFY_SOURCE=3 -Wp,-D_GLIBCXX_ASSERTIONS -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -fstack-protector-strong -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -m64 -mtune=generic -fasynchronous-unwind-tables -fstack-clash-protection -fcf-protection -fno-omit-frame-pointer -mno-omit-leaf-frame-pointer -fPIC -fvisibility=hidden -shared -o firebird_fdw.so src/connection.o src/convert.o src/firebird_fdw.o src/options.o -L/usr/pgsql-16/lib  -Wl,-z,relro -Wl,--as-needed  -Wl,-z,now -specs=/usr/lib/rpm/redhat/redhat-hardened-ld -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1  -Wl,--build-id=sha1   -L/usr/lib64  -L/usr/lib64 -Wl,--as-needed -Wl,-rpath,'/usr/pgsql-16/lib',--enable-new-dtags -fvisibility=hidden -lfq -lfbclient 
src/firebird_fdw.c:2103:17: error: call to undeclared function 'bms_first_member'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
                while ((col = bms_first_member(tmpset)) >= 0)
                              ^
src/firebird_fdw.c:2103:17: note: did you mean 'bms_is_member'?
/usr/pgsql-16/include/server/nodes/bitmapset.h:92:13: note: 'bms_is_member' declared here
extern bool bms_is_member(int x, const Bitmapset *a);
            ^
1 error generated.

[ibarwick]

Hi Devrim

Are you sure you're building from current sources? I fixed this in e52c85f.

Ian

[devrimgunduz]

Hi Ian,

I'm building from latest tarball, as usual :-D No rush, I'll try again when you release a new version.

Thanks! Devrim

[ibarwick]

Hi Devrim

1.3.1 release with Pg16 support now available: https://github.com/ibarwick/firebird_fdw/releases/tag/1.3.1

Thank

Ian

[devrimgunduz]

Thanks!