search

ibaton / bukkit-openhab-plugin

Eclipse Public License 2.0
5 stars 5 forks source link

Consider moving this plugin to openHAB 2 #2

Open kaikreuzer opened 7 years ago

kaikreuzer commented 7 years ago

Once the Minecraft binding is merged, I think it would make sense to have this plugin hosted at https://github.com/openhab/openhab2-addons as well, so that future contributors that might want to add additional features can do so on the server and binding side in sync. Do you see any reason that speaks against this?

ibaton commented 7 years ago

Despite the name of the bukkit pluggin, https://github.com/ibaton/bukkit-openhab-plugin/tree/master, I think it would probably be a better idea to keep the two separated. There is nothing OpenHAB specific in the bukkit plugin and it could potentially expose the server data to other HA systems. does this make sense?

kaikreuzer commented 7 years ago

While the code has no direct dependencies on openHAB, there are a lot of functional dependencies. I can imagine a lot of further features being added (locations of switches or whatever else) that will need synchronized code changes between the plugin and the binding; so being able to do this within a single PR is much, much easier than getting first changes into the plugin, wait for a new release of it and then get the other part of the code into the binding.

ibaton commented 7 years ago

It just feels like we are mixing the code for the service bindings with service itself. But I'll put it in if you think that its the right thing to do.

kaikreuzer commented 7 years ago

I'll leave the decision to you. If you plan to use this plugin for other purposes than openHAB integration and it might evolve on its own, having releases and active maintenance, I'd think it is ok to keep as a project on its own. If the only purpose is really the usage with openHAB, moving it imho will make many things easier (and release you from the burden of actively managing this project).