Provide alternatve to the resource bundle mechanism #7 FIX

ibauersachs / dnssecjava

A DNSSEC validating stub resolver for Java.

Other

43 stars 15 forks source link

Provide alternatve to the resource bundle mechanism #7 FIX #9

Closed techguy613 closed 8 years ago

techguy613 commented 8 years ago

Add setBundle() to R in order to manually set the ResourceBundle
Update R.get() to handle MissingResourceException by using printing "key:param1:...:paramN"

coveralls commented 8 years ago

Coverage decreased (-0.6%) to 94.582% when pulling 702bab666958a7cb11c0e41a76149e0a55a968e5 on techguy613:master into bab567de2715becb675a94522d048ddbdfa79d4b on ibauersachs:master.

ibauersachs commented 8 years ago

Thanks! This doesn't yet catch the case when the ResourceBundle isn't set manually and cannot be loaded automatically, the fallback is only effective if the key is actually not available. Without testing it, I'd even assume that the attempt to call setBundle would crash on Android.

coveralls commented 8 years ago

Coverage decreased (-0.7%) to 94.44% when pulling 98d244e63d0cf8c8c1cfa535f3d00d73480a2718 on techguy613:master into bab567de2715becb675a94522d048ddbdfa79d4b on ibauersachs:master.