search

ibauersachs / otr4j

Off-the-Record messaging library for Java
Apache License 2.0
65 stars 42 forks source link

Enable assembly plugin for a jar with deps #17

Closed languitar closed 9 years ago

languitar commented 9 years ago

Adds a maven-assembly-plugin section to the pom.xml which allows to construct a single jar containing all dependencies.

This is handy e.g. for the xabber project, where a single otr4j jar can be included on the library path.

gpolitis commented 9 years ago

Does this make it impossible to create a jar that doesn't contain all the dependencies? Sorry if the answer is obvious, I'm not a maven wizard :)

languitar commented 9 years ago

No, mvn package will just generate two different jars, the normal one and one with a suffix containing everything.

gpolitis commented 9 years ago

OK, that's great, thank you. Before we accept your contribution we need you to sign our contributor agreement. Apologies for the inconvenience, but unfortunately we cannot avoid it.

gpolitis commented 9 years ago

I'm closing the PR because I can't merge it without a signed CLA.