search

ibauk / sm3

ScoreMaster v3 application only
MIT License
0 stars 2 forks source link

EBC reject, manual override not right #4

Closed ibauk closed 2 years ago

ibauk commented 2 years ago

v3.1.1

If you use EBC Claiming and reject a Bonus it shows this Bonus in Red in the Scorecard. à OK

Now RM decide to give the rider this Bonus – Open Scorecard, unmark the checkbox (red goes to neutral), re tick the box – number goes to green à a) Points will not be added in the header line, b) after Saving and reopening the scorecard it’s still red again.

Only Solution I found à Send again a picture by email for this bonus, accept it and all is OK.

ibauk commented 2 years ago

This is a general tickbonus condition, nothing to do with EBC.

If a bonus is rejected then unticking the rejected bonus does not clear the BonusesVisited field so that the rescored bonus doesn't count.

Potential fixes are:- make unticking correctly clear BonusesVisited or set onclick/onchange to ignoreTick for rejected bonuses.

ibauk commented 2 years ago

The problem is that unticking a rejected bonus does not clear the associated entry in the field RejectedClaims

ibauk commented 2 years ago

Cleared in v3.1.2